Skip to content

Updates to Backup & Recovery section - #892

Merged
GBKS merged 48 commits into
masterfrom
feature/dsw-backup-recovery-2
Aug 24, 2022
Merged

GBKS merged 48 commits into
masterfrom
feature/dsw-backup-recovery-2

Conversation

@sbddesign

@sbddesign sbddesign commented Aug 12, 2022 •

Copy link
Copy Markdown
Collaborator

Updates to DSW Backup & Recovery. For #763.

💻 Deploy Preview

@netlify

netlify Bot commented Aug 12, 2022 •

Copy link
Copy Markdown

✅ Deploy Preview for bitcoin-design-site ready!

Name Link
🔨 Latest commit 39c5af2
🔍 Latest deploy log https://app.netlify.com/sites/bitcoin-design-site/deploys/6303ae76d5eed800083b3b0c
😎 Deploy Preview https://deploy-preview-892--bitcoin-design-site.netlify.app/guide/contribute/formatting/media
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sbddesign sbddesign added Daily spending wallet Referring to the Daily spending wallet reference design section. Copy Task is about improving text. Design Task is about designing something. labels Aug 12, 2022
@sbddesign
sbddesign marked this pull request as ready for review August 14, 2022 22:44
@sbddesign

Copy link
Copy Markdown
Collaborator Author

Ready for review on this one. Curious to hear what people think about the How to talk about a recovery phrase section. This content feels out of place to me now that we have expanded the UI flows for every page. Perhaps we should make a graphic that points out in the UI where these sorts of phrases are reflected, as @Bosch-0 suggested? Or perhaps we just strike this altogether and let the text stand for itself within the UI flows?

@sbddesign
sbddesign requested review from Bosch-0 and GBKS August 14, 2022 22:53
@GBKS GBKS linked an issue Aug 15, 2022 that may be closed by this pull request

@GBKS GBKS left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Just had a handful of minor comments.

Regarding the copywriting tips in manual backup, I think it's good to leave it in there. Shows how much care needs to go into these words in this sensitive user flow.

%}

{% include picture.html
image = "/assets/images/guide/daily-spending-wallet/backup-and-recovery/recovery/restore-manual-recovery-phrase-progress.png"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add auto-complete here, as it's enough to enter the first few characters usually.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss this here before I make another commit. My initial thought is that it should be separate and distinct from the OS level autocomplete. The whole advantage is that it should pull from the limited 2048 word BIP39 dictionary.

We can show one screen where we use autocorrection to prevent an error. The below is similar to the existing screen, but we are instead detecting if the word is wrong before the user even finishes typing it. There's no poi words after point in the dict, so the app can assume poil is a typo.

restore-manual-recovery-phrase-error

Then we can show an example of where autocomplete prevents the user from having to type in a long word. In this case, hospital, because there are no other hosp words in the dict.

restore-manual-recovery-phrase-progress

With the above picture, I was thinking about how the user takes advantage of the autocomplete. Do they just tap the word to have it fill automatically? Would they know to do this? What if the autocorrect stood out more? So I made the below image, which would be a little popup that shows the closest guess. The popup is the same color as the primary button, so I think it would stand out as something you interact with.

restore-manual-recovery-phrase-progress-1

Another option might be to have a custom autocomplete bar above the keyboard, but that might look kind of tacky in place of the OS autocomplete.

Thoughts?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the OS autocomplete, as long as it only uses words from the word list that is. Also its only required to enter the first 4 letters for each entry, could mention this.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stephen and I discussed yesterday. Option 2 seems the way to go, as OS autocompletes don't allow for custom dictionaries. URL bars also have a similar approach to option 2.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bosch-0 I decided against the OS autocomplete. It's doesn't matter to me if feeding the OS autocomplete a custom dictionary is possible or not, because the user may not understand this. Seeing words from their recovery phrase start appearing in the autocomplete might feel somewhat alarming, like the phone is tracking their bitcoin activity or something.

Instead, I added something that I hope feels more familiar to how autocomplete would work in a mobile web browser.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new design you went for, except for the light blue, doesn't seem to go with everything else.

Stephen DeLorme and others added 12 commits August 18, 2022 16:36
Co-authored-by: bosch <55287964+Bosch-0@users.noreply.github.com>
Co-authored-by: bosch <55287964+Bosch-0@users.noreply.github.com>
Co-authored-by: bosch <55287964+Bosch-0@users.noreply.github.com>
…nto feature/dsw-backup-recovery-2

# Conflicts:
#	guide/daily-spending-wallet/backup-and-recovery/manual-backup.md
Co-authored-by: bosch <55287964+Bosch-0@users.noreply.github.com>
Co-authored-by: bosch <55287964+Bosch-0@users.noreply.github.com>
@sbddesign
sbddesign requested review from Bosch-0 and GBKS August 19, 2022 11:38

@GBKS GBKS left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked through the whole thing again and it looks super good. Just some tiny nitpick stuff I found. Let's get this one out into the world.

@sbddesign

Copy link
Copy Markdown
Collaborator Author

Updated. Ready for another review @GBKS.

@GBKS GBKS left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK. Awesome work, Stephen. Super cool to see this one go live.

@GBKS
GBKS merged commit 88b9f8f into master Aug 24, 2022
@GBKS
GBKS deleted the feature/dsw-backup-recovery-2 branch December 20, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Copy Task is about improving text. Daily spending wallet Referring to the Daily spending wallet reference design section. Design Task is about designing something.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

📱 Revise Daily spending wallet -> Backup & Recovery section

3 participants